revdep do fails to install because of selective exports

[tdhock]

Since #5988
revdep do is failing to install:

(base) tdhock@tdhock-MacBook:~/R/data.table((HEAD détachée sur 83b0cf5e))$ LANGUAGE=en R -e 'install.packages("do")'

R version 4.3.2 (2023-10-31) -- "Eye Holes"
Copyright (C) 2023 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)

R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.

  Natural language support but running in an English locale

R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.

Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.

Loading required package: grDevices
> install.packages("do")
trying URL 'http://cloud.r-project.org/src/contrib/do_2.0.0.0.tar.gz'
Content type 'application/x-gzip' length 49366 bytes (48 KB)
==================================================
downloaded 48 KB

Loading required package: grDevices
* installing *source* package ‘do’ ...
** package ‘do’ successfully unpacked and MD5 sums checked
** using staged installation
** R
** inst
** byte-compile and prepare package for lazy loading
Loading required package: grDevices
Error: object ‘.__T__[:base’ is not exported by 'namespace:data.table'
Execution halted
ERROR: lazy loading failed for package ‘do’
* removing ‘/home/tdhock/lib/R/library/do’

The downloaded source packages are in
	‘/tmp/Rtmp7KoqJs/downloaded_packages’
Updating HTML index of packages in '.Library'
Making 'packages.html' ... done
Warning message:
In install.packages("do") :
  installation of package ‘do’ had non-zero exit status
> 

[MichaelChirico]

must be an S4 thing, we may need some importClassesFrom(methods, ...) entries. or maybe do needs to add those and was relying on data.table to register classes for them. l'll take a look

[tdhock]

@Nj221102 can you please investigate as well?

[Nj221102]

@Nj221102 can you please investigate as well?

sure :)

[Nj221102]

@Nj221102 can you please investigate as well?

As @MichaelChirico said this problem is happening due to switching from blanket importing(method package) to selective imports and can be temporarily fixed by moving back to blanket imports for Method package.

I have a question do you know what this .__T__[:base object might be , i can't find it .

[MichaelChirico]

Hmm I think this should be a {do} bug, it's extremely peculiar to do this:

https://github.com/cran/do/blob/fa0d7c8f9799326ffa6f0763f490c2873597131b/NAMESPACE#L132

It's literally the only package on CRAN that does so:

https://github.com/search?q=org%3Acran+path%3ANAMESPACE+%2F%5B.%5D__%2F+-path%3A.R&type=code

[MichaelChirico]

BTW, this object is a "meta name", I don't know the details about why they exist, but this is related to S4 methods for [:

methods:::.TableMetaName("[", "base")
# [1] ".__T__[:base"

https://github.com/r-devel/r-svn/blob/bfdb999d40cd1ac802adfa1c96a9fe905b21fe63/src/library/methods/R/methodsTable.R#L1294-L1295

[tdhock]

looks like this is happenening again since #6004

[MichaelChirico]

yep, that's intentional. the PR downstream is linked above -- they'll have had plenty time to fix it by the time we release.

[tdhock]

great