bug: universal patches are always shown

[Ushie]

Bug description

Universal patches are shown in the patches selector screen regardless of whether or not "Experimental universal patches support" is enabled in ReVanced Manager settings

Solution

Hide universal patches in patches selector if the setting is not toggled on

Acknowledgments

• I have searched the existing issues; this is new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I properly filled out all of the requested information in this issue.
• The issue is solely related to ReVanced Manager and not caused by patches.

[TheAabedKhan]

Are they just shown or selectable as well?? If they are not selectable then that's not an issue because user needs to see that there are other patches as well which are, although, disabled.

However, If they are causing disturbance in patches selection, I can add a chip that can hide/show unsupported patches, but they will be able to use them only after enabling the toggle in the settings page.

[Ushie]

They are selectable, that's where the issue lies, people with universal patches not toggled on might not realise that these patches aren't specific to that package, as it looks like any other, it might be good to separate them too or add an indicator

[TheAabedKhan]

I am unable to reproduce your issue. Can you send a screen recording?

[Ushie]

[TheAabedKhan]

Oh, ok! I got confused between experimental patches and universal patches.

You are right! PR on the way.

[ILoveOpenSourceApplications]

Can we consider #888 to be solved with this implementation as well?

[TheAabedKhan]

@ILoveOpenSourceApplications I will create a new PR for #888 which will actually separate them. Right now, if universal patches are enabled, they are mixed with the other patches.

[ILoveOpenSourceApplications]

Yes, so either we can hide universal patches and only show it to users who enable them in settings or have what the user in #888 say, a separate section for universal patches be implemented. I think one or the other is enough and implementing both would be unnecessary. Any opinion?

[TheAabedKhan]

I think one or the other is enough and implementing both would be unnecessary.

A separate section like this can help easily separate the universal patches even though all the patches are shown on the same page.

[Ushie]

Yes, so either we can hide universal patches and only show it to users who enable them in settings or have what the user in #888 say, a separate section for universal patches be implemented. I think one or the other is enough and implementing both would be unnecessary. Any opinion?

Implementing both is definitely necessary:

1. your average consumer has no idea what the difference between universal and package-specific patches is
2. there is no differentiator between universal and package-specific patches, so even ones that know the difference would be unable to specify which is which

[validcube]

🎉 Hooray! This issue have been fixed in #1087, please wait for the next version of ReVanced Manager.

Feel free to reopen if you like to suggest another solution.