Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: downloader plugin system #1474

Open
4 tasks done
Axelen123 opened this issue Nov 8, 2023 · 2 comments · May be fixed by #2041
Open
4 tasks done

feat: downloader plugin system #1474

Axelen123 opened this issue Nov 8, 2023 · 2 comments · May be fixed by #2041
Assignees
Labels
Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager

Comments

@Axelen123
Copy link
Member

Axelen123 commented Nov 8, 2023

Feature description

A plugin system for downloaders should be implemented.

Motivation

Maintaining plugins for many different APK providers is a burden that would be better dealt with by the community.

Implementation details

(The arrow labeled null is pointing to "Select downloader")
image

Plugins are jar files that can be loaded by DexClassLoader. They can be imported from local storage or downloaded from a remote source just like patch bundles. Plugins will have a manifest.json file which contains information about the plugin such as the name and which class to load. The specified class will implement the AppDownloader interface. A repository class will manage all plugins. Plugin information can be stored using room database if needed.

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The issue is solely related to the ReVanced Manager
@Axelen123 Axelen123 added Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager labels Nov 8, 2023
@oSumAtrIX
Copy link
Member

Please add implementation details to the issue.

@Axelen123
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants