Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't crash installation when saving last APK is disabled #2128

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

BenjaminHalko
Copy link
Member

closes: #2125

@oSumAtrIX oSumAtrIX changed the title fix: disabling Save Last APK no longer crashes installer fix: Don't crash installation when saving last APK is disabled Aug 10, 2024
@oSumAtrIX oSumAtrIX requested review from Axelen123 and removed request for oSumAtrIX August 10, 2024 18:59
Copy link
Member

@Axelen123 Axelen123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if the pubspec.lock changes belong here or not, but I don't have anything else to comment on.

@oSumAtrIX oSumAtrIX merged commit 427928e into dev Aug 11, 2024
1 check passed
@BenjaminHalko BenjaminHalko deleted the fix/save-apk-disabled branch August 11, 2024 15:38
github-actions bot pushed a commit that referenced this pull request Aug 11, 2024
## [1.21.2-dev.2](v1.21.2-dev.1...v1.21.2-dev.2) (2024-08-11)

### Bug Fixes

* Don't crash installation when saving last APK is disabled ([#2128](#2128)) ([427928e](427928e))
github-actions bot pushed a commit that referenced this pull request Aug 11, 2024
## [1.21.2](v1.21.1...v1.21.2) (2024-08-11)

### Bug Fixes

* Add haptics to save last APK switch ([#2133](#2133)) ([e063b3d](e063b3d))
* Don't crash installation when saving last APK is disabled ([#2128](#2128)) ([427928e](427928e))
* Don't crash when installing the last patched APK ([#2131](#2131)) ([cb722f2](cb722f2))
* Unable to scroll in the removed patches dialog ([#2113](#2113)) ([295c5a7](295c5a7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Patched file deleted after patching if "Save last APK" in settings is toggled off
3 participants