-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug:brut.common.BrutException #2142
Comments
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Anyone else experiencing the issue please try the new Compose manager: https://github.com/ReVanced/revanced-manager/actions/runs/10406703145/artifacts/1816419368 You will need to be logged into GitHub to download it. If you still get the error, send it & try the experimental and the multithreading toggle the advanced settings. If it errors out again, send the error logs. |
Tried the debug manager with latest patches, v4.13.3 with different options, same issue with Gphotos v6.95.0. App patch options are default. Logs with default advanced options, please excuse formatting issue since I'm on mobile:
|
Looks like this can be fixed fairly similarly to a fix yesterday. @LisoUseInAIKyrios Looks like we need some filter or escape certain characters in strings. |
The strings here are part of Google Photos, so it will need a bit more code to try and fix. It's odd because this issue does not show up when using CLI. It makes me wonder if during decoding if the files created have some default file encoding that is different from what CLI does. |
I think this is some regional issue. I remember a similar issue from a past time which we solved by explicitly setting the local in the code, otherwise on chinese locales CLI would spit an error (iirc aapt). So affected users should try setting their language to English and confirm this hypothesis |
I can reproduce the issue and I have my locale set to English. Manager Compose has the same problem. Figuring out why this works on CLI but fails when running in Manager is the best answer. Does Manager effectively run the same patching code as CLI? Are there any differences in any aapt flags or parameters? If anyone can inspect the decoded files extracted by Manager, it would be helpful to find what file encoding these decoded string files are saved as. |
Perhaps it's an issue with where AAPT is running. Have you tried running CLI via a terminal emulator like termux? You need to pass an AAPT binary compiled for your arch via an CLI option (check --help), preferably the ones checked in Managers source (or compile from source https://github.com/revanced/aapt2) |
Patching using CLI tools in Termux works without problems. I guess that is expected since it's still running in a Java JRE which makes it the same as patching on a computer. |
Are the decoded strings.xml files same? Maybe the issue occurs at decoding, not compiling. |
I'm not sure how to get the decoded string files Manager creates, so I can't compare. |
It creates a temporary folder under /data/data//cache. You'd need to have root access on your Android emulator to read that folder via another app like a file manager. |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Seems like the issue on Photos is related to the GmsCore patch specifically, every other patch other than GmsCore works fine but GmsCore causes the error for some reason. |
Try any resource patch such as change package name patch |
@Einheit-101 @avinashkarhana @MerBudd @oSumAtrIX @typecasto pfa reference |
Yeah they work too I already checked |
Interesting, reach out to [email protected] so we can test changes and see if it fixes the issue |
Hmm, and what should I write to them? I didn't even know they had an e-mail address like that. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
@np84295 #2192 (comment) please do what's described in this discussion. |
I noticed that if you only apply 'spoof features' to Google photos then it succeeded with compiling but the apk doesn't installs and says installation failed (though I have already uninstalled pre-built photos app with adb). And if I select 'GmsCore support' patch then it also patches another patch automatically which is 'Change package name' and throws an error (errno 2)mostly at 'compiling modified resources'. |
Manager Data was cleared, all patching options were selected. |
I can confirm that version worked. UPDATE: The apk was complied successfully, but photos weren't backing up. I commented too soon. |
Bug description
An error occurred:
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/data/app/~~9eVt2X873U6hrflJIuBFNg==/app.revanced.manager.flutter-Fan930Ft9a-j0mtAlCHU0A==/lib/arm64/libaapt2.so, compile, --dir, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-LJPSVO/revanced-temporary-files/apk/res, --legacy, -o, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-LJPSVO/revanced-temporary-files/apk/build/resources.zip]
at brut.androlib.AaptInvoker.invokeAapt2(Unknown Source:144)
at brut.androlib.AaptInvoker.invokeAapt(Unknown Source:106)
at app.revanced.patcher.data.ResourceContext.get(SourceFile:0)
at app.revanced.patcher.Patcher.get(SourceFile:0)
at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$35(Unknown Source:462)
at app.revanced.manager.flutter.MainActivity.$r8$lambda$t9VOe3aFJZkCMY59Ya4Pcinu-pA(SourceFile:0)
at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda6.run(SourceFile:0)
at java.lang.Thread.run(Thread.java:1012)
Caused by: brut.common.BrutException: could not exec (exit code = 1): [/data/app/~~9eVt2X873U6hrflJIuBFNg==/app.revanced.manager.flutter-Fan930Ft9a-j0mtAlCHU0A==/lib/arm64/libaapt2.so, compile, --dir, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-LJPSVO/revanced-temporary-files/apk/res, --legacy, -o, /data/user/0/app.revanced.manager.flutter/cache/patcher/tmp-LJPSVO/revanced-temporary-files/apk/build/resources.zip]
at brut.util.OS.exec(Unknown Source:75)
at brut.androlib.AaptInvoker.invokeAapt2(Unknown Source:122)
... 7 more
Version of ReVanced Manager and version & name of app you are patching
Device Info
ReVanced Manager: 1.21.2
Model: SM-S911B
Android version: 14
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No
Patch Info
App: com.google.android.youtube v19.16.39 (Suggested: 19.16.39)
Patches version: v4.13.2
Patches added: Default
Patches removed: None
Default patch options changed: None
Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: false
Patches source: revanced/revanced-patches
Integration source: revanced/revanced-integrations
revanced-manager_logcat_20240816012424228918.log
Installation method
Regular
ReVanced Manager logs
Patch logs
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: