Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Required minimum patcher version annotation or JSON export #223

Open
3 tasks done
LisoUseInAIKyrios opened this issue Aug 27, 2023 · 3 comments
Open
3 tasks done
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@LisoUseInAIKyrios
Copy link
Contributor

Type

Functionality

Issue

Too many people fail to update Manager, and then they wonder why it's throwing class not found exceptions during patching.

Feature

Create a minimum patcher version annotation that is applied to patches (apply it to some core patch such as integrations patch).

Or alternatively export something in the patches.json that indicates the minimum patcher version that is required to use the patches.

Then when a breaking patcher change is introduced, update the patches required minimum patcher field.

Then if Manager/CLI tries to patch and it's below the minimum patcher version, throw an error explaining to update.

Motivation

Help users who get so lost when they neglect updating Manager.

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@LisoUseInAIKyrios LisoUseInAIKyrios added the Feature request Requesting a new feature that's not implemented yet label Aug 27, 2023
@oSumAtrIX
Copy link
Member

oSumAtrIX commented Aug 27, 2023

I think this can be achieved without the help of ReVanced Patcher. The build system can add the version of ReVanced Patcher used to compile patches into the jar file as a resource.

Although PatchBundleLoader may want to be aware of it

@LisoUseInAIKyrios
Copy link
Contributor Author

Whatever way that works, sure. The point is to prevent patching and give feedback if the user has an outdated patcher.

@oSumAtrIX
Copy link
Member

This was previously an issue with breaking API changes. Currently, we handle this with more care and deprecation which will mitigate the issue in combination with ReVanced Manager showing a popup if an update is present. This could be enough to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

2 participants