Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fuzzy scanner failing if instructions are missing #89

Open
oSumAtrIX opened this issue Aug 19, 2022 · 0 comments · May be fixed by #115
Open

bug: fuzzy scanner failing if instructions are missing #89

oSumAtrIX opened this issue Aug 19, 2022 · 0 comments · May be fixed by #115
Labels
Bug report Something isn't working

Comments

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Aug 19, 2022 •
edited
Loading

Type

Other

Bug description

If a pattern of a fingerprint is missing an opcode or has more opcodes than expected, the fuzzy scan will fail. Currently the fuzzy scan only allows wrong opcodes only.

Steps to reproduce

  1. Create a fingerprint with a reasonable opcode pattern size
  2. Fuzzy scan it
  3. Change one opcode and confirm the fuzzy scanner works as expected
  4. Remove an opcode and confirm the fuzzy scanner now fails

Solution

A proper fuzzy scanning algorithm should be used instead of the current barebone implementation.
@oSumAtrIX oSumAtrIX added the Bug report Something isn't working label Aug 19, 2022
@MewtR MewtR linked a pull request Oct 10, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: slightly better fuzzy scanning MewtR/revanced-patcher
1 participant
@oSumAtrIX