Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arkane takes a long time to run due to loading Julia dependencies #2547

Open
jonwzheng opened this issue Sep 20, 2023 · 8 comments · May be fixed by #2631
Open

Arkane takes a long time to run due to loading Julia dependencies #2547

jonwzheng opened this issue Sep 20, 2023 · 8 comments · May be fixed by #2631

Comments

@jonwzheng
Copy link
Contributor

Bug Description

Running Arkane.py takes much longer than expected (i.e. close to 1 hour rather than 1 second on a local machine) for simple TST calculations.

How To Reproduce

Go to RMG-Py/examples/arkane/reactions/ and run Arkane.py on any of the input.py files in any of the examples.
You will see that Arkane starts executing, but slows down as it starts processing the Julia imports.

Expected Behavior

Arkane should finish running in just a few seconds.

Installation Information

  • Ubuntu 20.04.6 LTS
  • install from source with Anaconda, RMG-Py tag 3.2.0-115-g87b96e1b0, RMG-database tag 3.2.0

Additional Context

The slowdown is from Arkane importing RMG's CoreEdgeReactionModel , which imports RMG reactors, which then import the Julia modules (loading the Julia stuff is really slow.)

Since I'm only using Arkane for conventional TST, I was able to get the runtime back to the expected ~1 seconds by commenting out all of the instances where CoreEdgeReactionModel or ExplorerJob are imported when Arkane.py is called.
@JacksonBurns JacksonBurns mentioned this issue Sep 21, 2023
Closed
6 tasks
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the stale stale issue/PR as determined by actions bot label Dec 20, 2023
@JacksonBurns
Copy link
Contributor

Patch in place in #2539, which might be cut down into smaller PRs one of which will exactly cover this issue.

@JacksonBurns JacksonBurns removed the stale stale issue/PR as determined by actions bot label Jan 8, 2024
@JacksonBurns JacksonBurns mentioned this issue Mar 1, 2024
Closed
5 tasks
@JacksonBurns JacksonBurns linked a pull request Mar 11, 2024 that will close this issue
Open
@mjohnson541
Copy link
Contributor

Arkane uses Julia for direct solution of the master equation ODE.

@JacksonBurns
Copy link
Contributor

Are you referring to the code that @hwpang pointed out here? #2631 (comment)

If that's the case then I think Arkane has alternative solution methods already built in and we could possibly just say that in order to use the (probably better) Julia ones, they need to add the Julia deps?

@github-actions GitHub Actions
Copy link

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

@github-actions github-actions bot added the stale stale issue/PR as determined by actions bot label Jun 11, 2024
@JacksonBurns
Copy link
Contributor

Fix nearing completion in #2631, not stale

@JacksonBurns JacksonBurns removed the stale stale issue/PR as determined by actions bot label Jun 11, 2024
@JacksonBurns JacksonBurns mentioned this issue Jun 19, 2024
Open
@github-actions GitHub Actions
Copy link

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

@github-actions github-actions bot added the stale stale issue/PR as determined by actions bot label Sep 10, 2024
@jonwzheng
Copy link
Contributor Author

Not stale, see above

@jonwzheng jonwzheng removed the stale stale issue/PR as determined by actions bot label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid Unnecessary Julia Operations + Optional RMS Installation JacksonBurns/RMG-Py
3 participants
@mjohnson541 @jonwzheng @JacksonBurns