Skip to content

Commit

Permalink
fix(bufferWhen): onComplete of closings determine buffers
Browse files Browse the repository at this point in the history
Change bufferWhen operator to allow its closing Observables to close the
buffer whenever the closing Observable emits 'complete'. This is in
agreement with functionality in RxJS 4 buffer operator. Important for
the test 'Observable.prototype.bufferWhen should emit buffers using
varying empty delayed closings'.
  • Loading branch information
Andre Medeiros authored and benlesh committed Oct 14, 2015
1 parent 9dd27d6 commit 5d28a38
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/operators/bufferWhen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,6 @@ class BufferClosingNotifierSubscriber<T> extends Subscriber<T> {
}

_complete() {
// noop
this.parent.openBuffer();
}
}

0 comments on commit 5d28a38

Please sign in to comment.