fix(zipAll): complete when the source is empty

#2426
ReactiveX · Mar 9, 2017 · 712fece · 712fece
1 parent 69d051b
commit 712fece
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/spec/operators/zipAll-spec.ts b/spec/operators/zipAll-spec.ts
@@ -723,4 +723,11 @@ describe('Observable.prototype.zipAll', () => {
     expectSubscriptions(a.subscriptions).toBe(asubs);
     expectSubscriptions(b.subscriptions).toBe(bsubs);
   });
+
+  it('should complete when empty source', () => {
+    const source = hot('|');
+    const expected =   '|';
+
+    expectObservable(source.zipAll()).toBe(expected);
+  });
 });
diff --git a/src/operator/zip.ts b/src/operator/zip.ts
@@ -145,6 +145,12 @@ export class ZipSubscriber<T, R> extends Subscriber<T> {
   protected _complete() {
     const iterators = this.iterators;
     const len = iterators.length;
+
+    if (len === 0) {
+      this.destination.complete();
+      return;
+    }
+
     this.active = len;
     for (let i = 0; i < len; i++) {
       let iterator: ZipBufferIterator<any, any> = <any>iterators[i];