Subject.asObservable() missing?

[frankbenoit]

Hi

either it is missing, or it is missing in the migration guide?

Frank

[staltz]

Missing in the migration guide. At least from my perspective it seems we are intentionally removing it instead of forgetting to add it. Is that correct @Blesh @kwonoj @trxcllnt ?

[benlesh]

Yes. Unless there's a compelling reason to add it.

[mattpodwysocki]

@Blesh of course there's a compelling reason to add it. For example, exposing Subjects directly is usually a code smell, instead you want to hide the ability for the consumer of the API to send next calls, etc to it, so to call asObservable prevents that.

[benlesh]

Fair, but is that a solid enough reason to add the weight to the type, though?

(honestly just playing devil's advocate)

[mattpodwysocki]

@Blesh absolutely, as there is little to no overhead in doing so as in RxJS v4 asObservable

[benlesh]

Yep. Just want the consideration in the issue. I totally agree we should add it.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.