Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operator): add timeout operator #244

Closed
benlesh opened this issue Sep 1, 2015 · 2 comments · Fixed by #245
Closed

feat(operator): add timeout operator #244

benlesh opened this issue Sep 1, 2015 · 2 comments · Fixed by #245
Assignees
@benlesh
Milestone
Alpha release

Comments

@benlesh
Copy link
Member

benlesh commented Sep 1, 2015

No description provided.

@benlesh benlesh added this to the Alpha release milestone Sep 1, 2015
@benlesh benlesh self-assigned this Sep 1, 2015
@benlesh
Copy link
Member Author

benlesh commented Sep 1, 2015

This operator is highly polymorphic in it's current form. In particular that second argument that actually changes the behavior depending on the type it's passed. Seems like it should be split into two operators.

@benlesh benlesh mentioned this issue Sep 1, 2015
Merged
@benlesh
Copy link
Member Author

benlesh commented Sep 1, 2015

I ended up going with timeout and timeoutWith to split the differing behaviors of the timeout overloads. The former is for sending an error on timeout, the latter is for subscribing to a specified Observable on timeout.

@benlesh benlesh added the PR: WIP label Sep 1, 2015
@kwonoj kwonoj mentioned this issue Aug 3, 2016
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benlesh benlesh

Labels
None yet
Projects
None yet
Milestone
Alpha release
Development

Successfully merging a pull request may close this issue.

feat(operator): add timeout and timeoutWith
1 participant
@benlesh