fix(windowCount): set default value for skip argument, do not emit em… #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pty buffer at the end
| } | ||
|
|
||
| _next(value: T) { | ||
| const count = (this.count += 1); | ||
| const startWindowEvery = this.startWindowEvery; | ||
| const startWindowEvery = (this.startWindowEvery > 0) ? this.startWindowEvery : this.windowSize; |
There was a problem hiding this comment.
As mentioned in #271 (comment), some function initialize default value to 0 and some sets it to null for number types. As same as previous changes only updates value but not default value since not sure which one's recommended.
staltz
pushed a commit
to staltz/RxJSNext
that referenced
this pull request
Oct 13, 2015
Fix bugs with windowCount. This commit reverts PR ReactiveX#273, in order to have windowCount pass comprehensive marble tests. windowCount must open the first window immediately, not when the first next() event arrives, to comply with legacy windowWithCount and with RxJS Next window and windowTime.
benlesh
pushed a commit
that referenced
this pull request
Oct 13, 2015
Fix bugs with windowCount. This commit reverts PR #273, in order to have windowCount pass comprehensive marble tests. windowCount must open the first window immediately, not when the first next() event arrives, to comply with legacy windowWithCount and with RxJS Next window and windowTime.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pty buffer at the end.
As same as
bufferCountimplementation fixed in #271, windowCount also does not sets default skip argument if it's not specified. This PRwindowCountto set default skip argument to size of window.