Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toPromise): include toPromise in build output #2923

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Oct 9, 2017

Description:
With latest PR to remove toPromise from operator set #2914, operator/toPromise is not included in dependency tree and won't be compiled. We'll remove this in v6 obviously, but it's breaking for v5.

Related issue (if exists):

@kwonoj kwonoj requested a review from benlesh October 9, 2017 01:52
@rxjs-bot
Copy link

rxjs-bot commented Oct 9, 2017

Messages
📖

CJS: 1346.0KB, global: 745.3KB (gzipped: 139.9KB), min: 145.4KB (gzipped: 30.9KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.453% when pulling c241ca0 on kwonoj:export-toPromise into 92547a0 on ReactiveX:master.

@benlesh benlesh merged commit f55bfa5 into ReactiveX:master Oct 9, 2017
@kwonoj kwonoj deleted the export-toPromise branch October 9, 2017 03:19
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5.5.0-beta.5] Cannot find module 'rxjs/operator/toPromise'
4 participants