fix(typings): relax throttle selector type #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me try to see changes soon. |
|
This PR appears to no longer be required. |
|
Whoops. It seems that I'm wrong and Git is smarter than I thought it was. |
|
Should be rebased, now. |
Generated by 🚫 dangerJS |
---3.3KB-green.svg?style=flat-square){kind=icon}
-+0.1KB-red.svg?style=flat-square){kind=icon}
benlesh
approved these changes
Jan 23, 2018
acutmore
pushed a commit
to youviewtv/rxjs-5
that referenced
this pull request
Jan 23, 2018
* test(throttle): add typings tests * fix(typings): relax throttle selector type Closes ReactiveX#3204 (cherry picked from commit e83fda7)
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes the typings for the
throttlemethod's selected observable toany- in line with the typings used for other methods that include selectors for notification observables. E.g.audit.Related issue (if exists): #3204 (also see PR #3169)