Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(never): no longer export never function #3386

Merged
merged 2 commits into from
Mar 8, 2018

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Mar 6, 2018

  • Updates every test that used never() to use NEVER
  • Also updates those tests to use proper imports and pipeables.

BREAKING CHANGE: no longer exported. Use the NEVER constant instead.

@benlesh benlesh requested a review from jayphelps March 6, 2018 22:20
@rxjs-bot
Copy link

rxjs-bot commented Mar 6, 2018

Warnings
⚠️

❗ Big PR (1)

Messages
📖

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

CJS: 1312.4KB, global: 697.8KB (gzipped: 114.3KB), min: 134.7KB (gzipped: 29.7KB)

Generated by 🚫 dangerJS

BREAKING CHANGE: no longer exported. Use the `NEVER` constant instead.
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of merge conflicts. but otherwise lgtm

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 97.408% when pulling 1f8224e on benlesh:never-say-never-again into d231053 on ReactiveX:master.

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants