Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sourcemaps in v6 #3479

Closed
Delagen opened this issue Mar 27, 2018 · 2 comments
Closed

Sourcemaps in v6 #3479

Delagen opened this issue Mar 27, 2018 · 2 comments
Assignees
@jasonaden
Labels
bug Confirmed bug

Comments

@Delagen
Copy link
Contributor

Delagen commented Mar 27, 2018

RxJS version: 6.0.0-beta.3

Code to reproduce: any webpack bundle

Expected behavior: no warnings

Actual behavior:
multiple warnings such as
(Emitted value instead of an instance of Error) Cannot find source file '../../../../../src/internal/observable/dom/WebSocketSubject.ts': Error: Can't resolve '../../../../../src/internal/observable/dom/WebSocketSubject.ts'

Additional information:
I think need to enable inlineSources in tsconfig.json
@benlesh
Copy link
Member

benlesh commented Mar 27, 2018

cc @jasonaden

@gms1 gms1 mentioned this issue Apr 1, 2018
Closed
@benlesh benlesh added the bug Confirmed bug label Apr 2, 2018
@jasonaden jasonaden mentioned this issue Apr 3, 2018
Merged
jasonaden added a commit to jasonaden/rxjs that referenced this issue Apr 3, 2018
@jasonaden
fix(sourcemaps): fix mappings for source maps so they will work
099adef 
Fixes ReactiveX#3479
jasonaden added a commit to jasonaden/rxjs that referenced this issue Apr 5, 2018
@jasonaden
fix(sourcemaps): fix mappings for source maps so they will work
0a656b4 
Fixes ReactiveX#3479
jasonaden added a commit to jasonaden/rxjs that referenced this issue Apr 5, 2018
@jasonaden
fix(sourcemaps): fix mappings for source maps so they will work
692e58b 
Fixes ReactiveX#3479
jasonaden added a commit to jasonaden/rxjs that referenced this issue Apr 6, 2018
@jasonaden
fix(sourcemaps): fix mappings for source maps so they will work
78f7ead 
Fixes ReactiveX#3479
benlesh pushed a commit that referenced this issue Apr 7, 2018
@jasonaden @benlesh
fix(sourcemaps): fix mappings for source maps so they will work (#3523)
32e7f75 
Fixes #3479
@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasonaden jasonaden

Labels
bug Confirmed bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasonaden @Delagen @benlesh