Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupedObservable is not exported from root #3551

Closed
evertbouw opened this issue Apr 11, 2018 · 4 comments · Fixed by #3556
Closed

GroupedObservable is not exported from root #3551

evertbouw opened this issue Apr 11, 2018 · 4 comments · Fixed by #3556
Assignees
Labels
bug Confirmed bug

Comments

@evertbouw
Copy link
Contributor

I'm using the type GroupedObservable, but I have to import this from /internal

import { GroupedObservable } from "rxjs/internal/operators/groupBy";

RxJS version:
6.0.0-terrific-rc.3

@benlesh
Copy link
Member

benlesh commented Apr 12, 2018

You're using it as a type or you're creating it with a constructor?

@evertbouw
Copy link
Contributor Author

As a type only, I liked to extract and reuse the inner function

@benlesh benlesh added bug Confirmed bug and removed status: more information needed labels Apr 12, 2018
@benlesh
Copy link
Member

benlesh commented Apr 12, 2018

Thanks, I'll look into it

@benlesh benlesh self-assigned this Apr 12, 2018
benlesh added a commit to benlesh/rxjs that referenced this issue Apr 12, 2018
We are now exporting the GroupedObservable type. This also marked the constructor as deprecated, as it is really for internal use only, and subject to change at any time.

fixes ReactiveX#3551
benlesh added a commit that referenced this issue Apr 12, 2018
We are now exporting the GroupedObservable type. This also marked the constructor as deprecated, as it is really for internal use only, and subject to change at any time.

fixes #3551
@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bug
Projects
None yet
2 participants