Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for repeat unsubscription #554

Closed
benlesh opened this issue Oct 16, 2015 · 1 comment
Closed

Add tests for repeat unsubscription #554

benlesh opened this issue Oct 16, 2015 · 1 comment
Labels
help wanted Issues we wouldn't mind assistance with.

Comments

@benlesh
Copy link
Member

benlesh commented Oct 16, 2015

We need to make sure that the source observable's tear down logic is called before everything repeats again, so we have to make sure we're unsubscribing from the previous subscription before repeating.

I don't think we have tests around this.
@benlesh benlesh added the help wanted Issues we wouldn't mind assistance with. label Oct 16, 2015
@staltz
Copy link
Member

staltz commented Oct 19, 2015

I can do this one.

staltz pushed a commit to staltz/RxJSNext that referenced this issue Oct 19, 2015
test(repeat): add unsubscription tests for repeat
c75e414 
Add tests for subscription/unsubscription moments of the repeatable
source for the repeat operator.

Resolves issue ReactiveX#554.
staltz pushed a commit to staltz/RxJSNext that referenced this issue Oct 19, 2015
fix(repeat): fix inner subscription semantics for repeat
95c10c8 
Fix repeat operator to unsubscribe from the repeatable source as soon as
possible (when the previous repetition was completed), not when the
resulting Observable was unsubscribed (which is as late as possible).
Also fix repeat operator to not subscribe to the source at all if
count=0.

Resolves ReactiveX#554.
@staltz staltz mentioned this issue Oct 19, 2015
Closed
benlesh pushed a commit that referenced this issue Oct 26, 2015
@benlesh
test(repeat): add unsubscription tests for repeat
d3ea639 
Add tests for subscription/unsubscription moments of the repeatable
source for the repeat operator.

Resolves issue #554.
@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@staltz @benlesh