Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @NonNull annotations for functions with void return type #7425

Merged
merged 1 commit into from
May 27, 2022
Merged

Remove @NonNull annotations for functions with void return type #7425

merged 1 commit into from
May 27, 2022

Conversation

pahakorolev
Copy link
Contributor

Minor code readability improvement, which does not make you wonder on @nonnull void type.

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #7425 (d184e40) into 3.x (23c9f4d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.x    #7425      +/-   ##
============================================
- Coverage     99.55%   99.55%   -0.01%     
  Complexity     6781     6781              
============================================
  Files           751      751              
  Lines         47482    47482              
  Branches       6378     6378              
============================================
- Hits          47272    47271       -1     
- Misses           92       96       +4     
+ Partials        118      115       -3     
Impacted Files Coverage Δ
...ain/java/io/reactivex/rxjava3/core/Observable.java 100.00% <ø> (ø)
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 91.74% <0.00%> (-6.43%) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0.00%> (-4.66%) ⬇️
...a/io/reactivex/rxjava3/subjects/SingleSubject.java 97.53% <0.00%> (-2.47%) ⬇️
...ernal/operators/flowable/FlowableFlatMapMaybe.java 95.85% <0.00%> (-0.52%) ⬇️
...a/io/reactivex/rxjava3/subjects/ReplaySubject.java 98.75% <0.00%> (-0.21%) ⬇️
...rnal/operators/flowable/FlowableFlatMapSingle.java 96.51% <0.00%> (ø)
...3/internal/operators/flowable/FlowableGroupBy.java 85.02% <0.00%> (+0.29%) ⬆️
.../operators/observable/ObservableCombineLatest.java 100.00% <0.00%> (+0.61%) ⬆️
...l/operators/observable/ObservableFlatMapMaybe.java 97.88% <0.00%> (+0.70%) ⬆️
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@akarnokd akarnokd merged commit 4a665c9 into ReactiveX:3.x May 27, 2022
@pahakorolev pahakorolev deleted the 3.x-remove-nonnull-from-void-function branch May 27, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants