Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestScheduler ColdObservable unable to emit synchronously #2169

Closed
benlesh opened this issue Dec 2, 2016 · 9 comments
Closed

TestScheduler ColdObservable unable to emit synchronously #2169

benlesh opened this issue Dec 2, 2016 · 9 comments
Assignees

Comments

@benlesh
Copy link
Member

benlesh commented Dec 2, 2016

According to @trxcllnt's comment here, cold('(a|)') will not synchronously emit a like Observable.of('a') would.

Observable.of('a') and cold('(a|)') should be equivalent.

@benlesh
Copy link
Member Author

benlesh commented Jan 25, 2018

@kwonoj is this still the case? This is a really old issue. Can you verify?

@kwonoj
Copy link
Member

kwonoj commented Jan 25, 2018

This is still an issue and tried attempt few way to resolve this but wasn't successful so far.

@benlesh
Copy link
Member Author

benlesh commented Jan 26, 2018

I guess we could just examine the marbles we get, and if all notifications are on 0, we synchronously subscribe. It'll be some gross conditionals, but it should work.

@kwonoj
Copy link
Member

kwonoj commented Jan 26, 2018

correct, I could make gross conditional but somehow failed to coordinate synchronous subscription with other marbles created. I'm feeling I did something very incorrect, just need some more trial & errors.

@benlesh
Copy link
Member Author

benlesh commented Jan 26, 2018

@kwonoj maybe put up a PR as a WIP and we can have a look?

@kwonoj
Copy link
Member

kwonoj commented Jan 26, 2018

makes sense, I'll prep it to anyone can see error I saw (and possibly can mock me about mistakes I made there :lol:)

@benlesh
Copy link
Member Author

benlesh commented Mar 16, 2018

This is something the new design @jayphelps and I came up with should cover.

@benlesh
Copy link
Member Author

benlesh commented Mar 16, 2018

As it's not something that is really a bug with the current ColdObservable, I'm going to close this.

@benlesh benlesh closed this as completed Mar 16, 2018
@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants