New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce Observable contract for Subjects #459

Closed

staltz opened this issue Oct 5, 2015 · 1 comment

Member

staltz commented Oct 5, 2015

While working on #428, I found this test which attempts to call onNext after an onError on a Subject. https://github.com/ReactiveX/RxJS/blob/master/spec/operators/bufferTime-spec.js#L62

I suppose Subjects should disallow this internally.

Member

benlesh commented Oct 5, 2015

Subjects already enforce this. That test is okay, but it should probably be refactored to prevent confusion.

benlesh closed this as completed

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.