Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linters for RxJS 7 deprecations #5380

Closed
timdeschryver opened this issue Apr 5, 2020 · 3 comments
Closed

Linters for RxJS 7 deprecations #5380

timdeschryver opened this issue Apr 5, 2020 · 3 comments

Comments

@timdeschryver
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe.

The RxJS 7 release includes a couple of deprecations, these were also highlighted in Ben's talk at ngconf.

Describe the solution you'd like

It would be useful to have linters that fix these for us, just like with the previous release.

Describe alternatives you've considered

/

Additional context

I'm not sure if someone is already working on this, but I started here with an implementation.

Currently, it covers the basics for:

  • result selectors
  • subscribe signature
  • tab signature
  • the deprecation of operators to operatorWith

This is just me trying to implement the linters, but I thought it could be of help, as a starting point.
It uses eslint and @typescript-eslint/parser under the hood.

Feel free to close this, or ping me if you need more information.
I also want to offer my help if we want to move forward with this and cover more cases.

The easiest way to run it is with the following command but be aware it will install eslint and @typescript-eslint/parser if needed.

npx eslint-plugin-rxjs-fixers-poc
@samal-rasmussen
Copy link
Contributor

@timdeschryver
Copy link
Contributor Author

I recently discovered ts-morph... and I used these deprecations as a POC to get familiar with ts-morph.

See rxjs-fixers-morph for the implementation to provide fixers for the RxJS 7 deprecations.

@samal-rasmussen
Copy link
Contributor

This seems to have been addressed here: #5843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants