-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getBundle$
can hang for a long time giving the impression that alignment has failed
#122
Comments
Alternately, since it's really the version resolution that is slow, if we can retrieve the exact version number that we used to build studio-web and then use that, this would be a vast improvement, since we wouldn't be hardcoding the versoin in our code anymore. |
We should consider using the version in Caveat: there's a bit of a chicken and egg problem: when we bump the version but haven't published it yet, how can In any case, using I understand the value of using |
why don't we just retrieve the bundle used when building studio-web. we can include it as an asset in the build? and then we just avoid unpkg altogether for our site. |
Yeah, totally! Great idea. |
ok I"ll do this |
thanks Aidan! fixed in #123 |
When you click on "Go to the next step!", one of the things that happens is this:
As we have established elsewhere (ReadAlongs/Studio#155) unpkg can be very quite slow. This mistakenly gives the impression that alignment has failed, when in fact we are just waiting to download our own code through an elaborate Internet Rube Goldberg machine.
It would be good to find a way to construct the bundle from our own copies of these things (realizing that this may be more difficult than it sounds) to avoid this problem
The text was updated successfully, but these errors were encountered: