-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(time-picker): add build-in validation for partial input value #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bualoy-napat
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
v6
EF version 6
unit-testing
Change related to testing
labels
May 20, 2024
Size Change: +1.76 kB (+0.11%) Total Size: 1.55 MB
ℹ️ View Unchanged
|
bualoy-napat
force-pushed
the
feat/error-state-for-partial-input-v6
branch
from
May 20, 2024 13:07
7e297ed
to
6cedd3c
Compare
Deploying refinitiv-ui with Cloudflare Pages
|
bualoy-napat
force-pushed
the
feat/error-state-for-partial-input-v6
branch
from
May 21, 2024 02:21
fac11db
to
101f522
Compare
…component and updated related tests
wattachai-lseg
requested changes
May 31, 2024
packages/elemental-theme/src/custom-elements/ef-time-picker.less
Outdated
Show resolved
Hide resolved
bualoy-napat
force-pushed
the
feat/error-state-for-partial-input-v6
branch
from
June 3, 2024 18:37
6dc8ce6
to
32321ba
Compare
wattachai-lseg
requested changes
Jun 4, 2024
packages/elemental-theme/src/custom-elements/ef-time-picker.less
Outdated
Show resolved
Hide resolved
wattachai-lseg
previously approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
wattachai-lseg
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
unit-testing
Change related to testing
v6
EF version 6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, time-picker was not provided any input feedback to Apps when the input is in the partial state. Therefore, we decided to extend
FormFieldElement
instead ofControlElement
and provide build-in validation to validate partial value in time-picker. Moreover, we also introducecustom-validation
API to disable build-in validation. it allows Apps to manage error state and validation base on their criteria.Things that include in this PR
custom-validation
API to disable build-in validation and allow user to make their own validationerror-changed
event for time-pickerreadonly
anderror
statetoggle
method that firevalue-changed
event when calltoggle
via APIFixes # (issue)
https://jira.refinitiv.com/browse/DME-11575
Checklist