Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: radio-button not add to group #167

Merged
merged 7 commits into from
Feb 14, 2022

Conversation

Jidapa-Pai
Copy link
Contributor

@Jidapa-Pai Jidapa-Pai commented Jan 14, 2022

Description

Ticket [coral-radio-button] button does not group when name is dynamic value. Found radio group does not work when assign dynamic name value to the element on angular project.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@wsuwt wsuwt self-requested a review January 14, 2022 11:39
@Jidapa-Pai Jidapa-Pai added the bug Something isn't working label Jan 19, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 28, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 699d5d0
Status: ✅  Deploy successful!
Preview URL: https://9c77be0e.refinitiv-ui.pages.dev

View logs

@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul merged commit fb05273 into develop Feb 14, 2022
@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul deleted the fix/radio-button-not-add-to-group branch February 14, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants