-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(slider): value-changed event is not fired #174
Conversation
Deploying with Cloudflare Pages
|
@TremayneChrist @goremikins Do you want to skim this PR before merging? |
I do not understand what is going on there and why as the code looks very messy :) but my guess is that the |
If you think the code should be refactored, we have the story for that one already and we can do in the next sprint. |
I agreed the code like messy to read. |
Description
Fixes # (issue)
Step to reproduce:
value
by Javascript. e.g. setvalue
from 0 to 10.Result: The
value-changed
event is not fired. Try to reproduce here https://codepen.io/jidapa-pai/pen/XWeQdeOThe problem is when user programmatically set
value
thevaluePrevious
which is internal value didn't update so when drag the slider back to previous value, it not detect value change and not fires thevalue-changed
event.So, the solution is to update
valuePrevious
when thevalue
was programmatically set.Type of change
Checklist