Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(button-bar): follow accessibility behavior #176

Merged
merged 15 commits into from
Feb 4, 2022
Merged

feat(button-bar): follow accessibility behavior #176

merged 15 commits into from
Feb 4, 2022

Conversation

Theeraphat-Sorasetsakul
Copy link
Collaborator

@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul commented Jan 25, 2022 •
edited
Loading

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
https://jira.refinitiv.com/browse/ELF-1721

https://www.w3.org/TR/wai-aria-practices/examples/toolbar/toolbar.html

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul marked this pull request as draft January 25, 2022 03:16
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 25, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 101d5ce
Status: ✅  Deploy successful!
Preview URL: https://fb63155c.refinitiv-ui.pages.dev

View logs

@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul marked this pull request as ready for review January 26, 2022 05:36
@dtanp-rft dtanp-rft added the accessibility Accessibility improvement label Jan 28, 2022
wsuwt
wsuwt reviewed Jan 31, 2022
View reviewed changes
packages/elements/src/button-bar/index.ts Outdated Show resolved Hide resolved
packages/elements/src/button-bar/index.ts Outdated Show resolved Hide resolved
packages/elements/src/button-bar/index.ts Outdated Show resolved Hide resolved
packages/elements/src/button/__test__/button.test.js Outdated Show resolved Hide resolved
wsuwt
wsuwt reviewed Feb 2, 2022
View reviewed changes
packages/elements/src/button-bar/__demo__/index.html Outdated Show resolved Hide resolved
packages/elements/src/button-bar/index.ts Show resolved Hide resolved
packages/elements/src/button-bar/index.ts Outdated Show resolved Hide resolved
packages/elements/src/button-bar/index.ts Show resolved Hide resolved
packages/elements/src/button-bar/index.ts Show resolved Hide resolved
packages/elements/src/button-bar/index.ts Outdated Show resolved Hide resolved
packages/elements/src/button-bar/index.ts Outdated Show resolved Hide resolved
@wsuwt
Copy link
Collaborator

wsuwt commented Feb 3, 2022

When it is ready, please squash and use improve screen reader support as commit message.

@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul merged commit f121ea6 into develop Feb 4, 2022
@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul deleted the feat/a11y-button-bar branch February 4, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsuwt wsuwt wsuwt approved these changes

@Sarin-Udompanish Sarin-Udompanish Awaiting requested review from Sarin-Udompanish

Assignees
No one assigned
Labels
accessibility Accessibility improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Theeraphat-Sorasetsakul @wsuwt @Sarin-Udompanish @dtanp-rft