Refactor code #311
Merged
Refactor code #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(utils): add date timestamps refactor(clock): use date utils refactor(clock): refactor code
Deploying with
|
| Latest commit: |
df27653
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://40a81d06.refinitiv-ui.pages.dev |
|
SonarCloud Quality Gate failed. |
Closed
|
@goremikins I decided that we should keep |
|
I'm going to merge this and edit it to no role by default in PR - feat(clock): improve clock accessibility |
Theeraphat-Sorasetsakul
approved these changes
May 20, 2022
Theeraphat-Sorasetsakul
added a commit
that referenced
this pull request
May 25, 2022
* feat(clock): improve clock accessibility * feat(phrasebook): clock translations (#311) * docs(clock): add accessiblity doc Co-authored-by: Aleksejs <[email protected]> Co-authored-by: Domrongpon Tanpaibul <[email protected]> Co-authored-by: wsuwt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wsuwt , @Theeraphat-Sorasetsakul I have refactored the code to what I think it should look like.
Please ensure that screen readers still work and fix tests.