Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clock): sync interactiveChange code with rating #346

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

Theeraphat-Sorasetsakul
Copy link
Collaborator

Description

Sync code to be same as interactiveChanged in Rating.
When interactive: check user tabindex before assign, set role, and set aria attributes.
When non interactive: remove role, don't change tabindex, remove aria attributes.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul added the accessibility Accessibility improvement label Jun 1, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 2, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e5091e
Status: ✅  Deploy successful!
Preview URL: https://e9e4c782.refinitiv-ui.pages.dev

View logs

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Theeraphat-Sorasetsakul Theeraphat-Sorasetsakul deleted the fix/clock-sync-code-with-rating branch June 2, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants