Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(slider): add localised label for slider thumb #351

Merged
merged 2 commits into from
Jun 7, 2022
Merged

feat(slider): add localised label for slider thumb #351

merged 2 commits into from
Jun 7, 2022

Conversation

wsuwt
Copy link
Collaborator

@wsuwt wsuwt commented Jun 6, 2022

Description

Adding translated aria-label to slider thumb.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@wsuwt wsuwt requested a review from goremikins June 6, 2022 13:42
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 6, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 539ba11
Status: ✅  Deploy successful!
Preview URL: https://63c164ab.refinitiv-ui.pages.dev

View logs

goremikins
goremikins previously approved these changes Jun 6, 2022
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wsuwt wsuwt merged commit ba9cc8d into v6 Jun 7, 2022
@wsuwt wsuwt deleted the add-translated-label-to-slider-thumb branch June 7, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sarin-Udompanish Sarin-Udompanish Sarin-Udompanish approved these changes

@goremikins goremikins goremikins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wsuwt @goremikins @Sarin-Udompanish @phetw