Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion): The element should interact only with its direct children #378

Merged
merged 3 commits into from
Jun 27, 2022

Conversation

Nantawat-Poothong
Copy link
Contributor

Description

The accordion listens to expanded-changed events from elements that aren't its direct children.

This PR is sync from v4 https://git.sami.int.thomsonreuters.com/elf/elements/merge_requests/200

Solution

  • Add a condition to check if the clicked element is coral-collapse

Fixes # (issue)
https://jira.refinitiv.com/browse/ELF-1638

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 24, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ea8aefb
Status: ✅  Deploy successful!
Preview URL: https://b130a95c.refinitiv-ui.pages.dev
Branch Preview URL: https://fix-coral-accordion-expanded.refinitiv-ui.pages.dev

View logs

@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Nantawat-Poothong Nantawat-Poothong merged commit f8e11d3 into v6 Jun 27, 2022
@Nantawat-Poothong Nantawat-Poothong deleted the fix/coral-accordion-expanded-changed branch June 27, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants