Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tab bar resize callback is not fired when a new tab added #389

Conversation

Sarin-Udompanish
Copy link
Collaborator

Description

Resize observer always observed on the root element but the contents of tab-bar are inside the content part so resizeCallback will not fired when new contents are modified or updated.

Fixes # (issue)
Resize callback is not fired when a new tab added

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 7, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e69bc6
Status: ✅  Deploy successful!
Preview URL: https://630078d3.refinitiv-ui.pages.dev
Branch Preview URL: https://fix-tab-bar-resize-callback-.refinitiv-ui.pages.dev

View logs

@wsuwt wsuwt added the bug Something isn't working label Jul 7, 2022
@wsuwt
Copy link
Collaborator

wsuwt commented Jul 8, 2022

LGTM. Did you test resizing on IE11 ?

@Sarin-Udompanish
Copy link
Collaborator Author

LGTM. Did you test resizing on IE11 ?

Yes i did. It work fine.

@wsuwt wsuwt self-requested a review July 8, 2022 06:44
wsuwt
wsuwt previously approved these changes Jul 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Sarin-Udompanish Sarin-Udompanish merged commit 13408e1 into v6 Jul 11, 2022
@Sarin-Udompanish Sarin-Udompanish deleted the fix/tab-bar-resize-callback-is-not-fired-when-a-new-tab-added branch July 11, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants