Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radio): improve radio button screen reader #43

Merged
merged 10 commits into from
Nov 2, 2021
Merged

feat(radio): improve radio button screen reader #43

merged 10 commits into from
Nov 2, 2021

Conversation

Jidapa-Pai
Copy link
Contributor

  • role radio
  • aria-checked state
  • Handle navigate between the option using keyboard arrow keys

@Jidapa-Pai Jidapa-Pai added the accessibility Accessibility improvement label Oct 21, 2021
@Jidapa-Pai Jidapa-Pai requested a review from wsuwt October 21, 2021 07:52
@Jidapa-Pai Jidapa-Pai self-assigned this Oct 21, 2021
wsuwt
wsuwt requested changes Oct 25, 2021
View reviewed changes
packages/elements/src/radio-button/__demo__/index.html Outdated Show resolved Hide resolved
packages/elements/src/radio-button/index.ts Outdated Show resolved Hide resolved
packages/elements/src/radio-button/index.ts Outdated Show resolved Hide resolved
packages/elements/src/radio-button/index.ts Outdated Show resolved Hide resolved
@wsuwt wsuwt marked this pull request as ready for review October 25, 2021 05:35
@wsuwt wsuwt self-requested a review October 26, 2021 07:34
@wsuwt wsuwt merged commit 12d2b23 into develop Nov 2, 2021
@wsuwt wsuwt deleted the feat/radio-a11y branch November 2, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsuwt wsuwt wsuwt approved these changes

Assignees

@Jidapa-Pai Jidapa-Pai

Labels
accessibility Accessibility improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jidapa-Pai @wsuwt @phetw