Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): tap event may be fired on wrong target on space key #81

Merged
merged 2 commits into from
Nov 18, 2021
Merged

fix(core): tap event may be fired on wrong target on space key #81

merged 2 commits into from
Nov 18, 2021

Conversation

goremikins
Copy link
Contributor

Description

Tap event may be fired on wrong target on space key.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@TremayneChrist TremayneChrist merged commit 0d8c9c5 into develop Nov 18, 2021
@TremayneChrist TremayneChrist deleted the fix/tap-event branch November 18, 2021 15:16
@Jidapa-Pai Jidapa-Pai mentioned this pull request Nov 19, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TremayneChrist TremayneChrist TremayneChrist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goremikins @TremayneChrist