Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree): correctly update dependant checked states #82

Merged
merged 6 commits into from
Nov 18, 2021

Conversation

TremayneChrist
Copy link
Collaborator

@TremayneChrist TremayneChrist commented Nov 17, 2021

Description

Correctly updates dependant item chacked states, when managing relationships.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Copy link
Collaborator

@dtanp-rft dtanp-rft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hope we can add new test case so we can regression test this in the future.

@TremayneChrist TremayneChrist merged commit fdb7018 into develop Nov 18, 2021
@TremayneChrist TremayneChrist deleted the bug/tree-selected-state branch November 18, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants