-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tooltip): add data-tooltip alias for tooltip attribute #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nantawat-Poothong
changed the title
feat(tooltip): add data-tooltip alias for tooltip attr
feat(tooltip): add data-tooltip alias for tooltip attribute
Jul 25, 2023
Size Change: +26 B (0%) Total Size: 1.56 MB
ℹ️ View Unchanged
|
bualoy-napat
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
React typescript show error tooltip property not found when using tooltip element with any EF elements.
Our tooltip have a feature to selector elements from tooltip property but tooltip property didn't provide to elements in typescript
Solution:
tootip attribute doesn't support from HTML standard by default? Well, add
data-tooltip
alias for tooltip attribute that consume by tooltip renderer to avoid alien attribute error. also data attributesdata-*
is following HTML standardRef: https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes
Fixes # (issue)
https://jira.refinitiv.com/browse/ELF-2115
Type of change
Please delete options that are not relevant.
Checklist