From f6deb350579cfb0339831889965e8383d216f1ea Mon Sep 17 00:00:00 2001 From: wattachai <117723407+wattachai-lseg@users.noreply.github.com> Date: Wed, 18 Jan 2023 15:34:16 +0700 Subject: [PATCH 1/2] fix(select): unset cursor of header items --- packages/elemental-theme/src/custom-elements/ef-select.less | 2 -- packages/elements/src/select/index.ts | 1 + packages/halo-theme/src/custom-elements/ef-select.less | 1 - packages/solar-theme/src/custom-elements/ef-select.less | 2 ++ 4 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/elemental-theme/src/custom-elements/ef-select.less b/packages/elemental-theme/src/custom-elements/ef-select.less index b13120214b..e955a3ddca 100644 --- a/packages/elemental-theme/src/custom-elements/ef-select.less +++ b/packages/elemental-theme/src/custom-elements/ef-select.less @@ -31,8 +31,6 @@ } // #endregion - cursor: pointer; - &[readonly] { cursor: default; } diff --git a/packages/elements/src/select/index.ts b/packages/elements/src/select/index.ts index 735c800479..919074565a 100644 --- a/packages/elements/src/select/index.ts +++ b/packages/elements/src/select/index.ts @@ -129,6 +129,7 @@ export class Select extends ControlElement implements MultiValue { right: 0; bottom: 0; left: 0; + cursor: pointer; } #select { position: absolute; diff --git a/packages/halo-theme/src/custom-elements/ef-select.less b/packages/halo-theme/src/custom-elements/ef-select.less index 4e3a409362..3d6aeec901 100644 --- a/packages/halo-theme/src/custom-elements/ef-select.less +++ b/packages/halo-theme/src/custom-elements/ef-select.less @@ -41,7 +41,6 @@ } } - cursor: pointer; [part=list] { color: @control-text-color; diff --git a/packages/solar-theme/src/custom-elements/ef-select.less b/packages/solar-theme/src/custom-elements/ef-select.less index 4df7526d6a..64371c5cff 100644 --- a/packages/solar-theme/src/custom-elements/ef-select.less +++ b/packages/solar-theme/src/custom-elements/ef-select.less @@ -9,6 +9,8 @@ // #region - Extend from ef-button styles &:extend(:host); + // unset ef-button's cursor style + cursor: unset; &:not([readonly]):hover { &:extend(:host:hover); } From 79d4cac091d13d8cf077ed29971357b05e8774b0 Mon Sep 17 00:00:00 2001 From: wattachai <117723407+wattachai-lseg@users.noreply.github.com> Date: Wed, 18 Jan 2023 16:21:45 +0700 Subject: [PATCH 2/2] fix(select) clarify comment --- packages/solar-theme/src/custom-elements/ef-select.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/solar-theme/src/custom-elements/ef-select.less b/packages/solar-theme/src/custom-elements/ef-select.less index 64371c5cff..66637d158c 100644 --- a/packages/solar-theme/src/custom-elements/ef-select.less +++ b/packages/solar-theme/src/custom-elements/ef-select.less @@ -9,7 +9,7 @@ // #region - Extend from ef-button styles &:extend(:host); - // unset ef-button's cursor style + // pointer cursor style would be applied internally to trigger element instead cursor: unset; &:not([readonly]):hover { &:extend(:host:hover);