Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy pagination required in the people->All contacts #38

Open
Kumaravinash9 opened this issue May 8, 2021 · 6 comments
Open

Lazy pagination required in the people->All contacts #38

Kumaravinash9 opened this issue May 8, 2021 · 6 comments

Comments

@Kumaravinash9
Copy link
Contributor

No description provided.

@rottencandy
Copy link
Member

We can either go with pagination, or fetch details lazily when id is scrolled into view.

We can also explore other options like memoizing the details, so it is only fetched once.

@Kumaravinash9 Kumaravinash9 changed the title Lazy pagaination required in the people->All contacts Lazy pagination required in the people->All contacts May 8, 2021
@Kumaravinash9
Copy link
Contributor Author

Kumaravinash9 commented May 8, 2021

Thanks @rottencandy If memoizing option fetches the details once then we should go with this option.

@defnax
Copy link
Contributor

defnax commented May 12, 2021

i had a issue here when i click all contacts rs freezes or the webui gets logged out

@Kumaravinash9
Copy link
Contributor Author

i had a issue here when i click all contacts rs freezes or the webui gets logged out

sorry @defnax for the late reply. Actually it was working perfectly in my case. And @rottencandy also checked when he merged the PR .

@Kumaravinash9
Copy link
Contributor Author

May be this conflits comes after merging AddSideNavbar PR

@rottencandy
Copy link
Member

i had a issue here when i click all contacts rs freezes or the webui gets logged out

This is probably due to having lots of contacts.
As of now in the contacts tab, there is an API request made for every single contact in the list.

So if there are 1000 contacts, the webui contacts tab makes 1000 http requests to RS in 1 second, which could be why the browser gets overwhelmed and freezes.

This model does not scale well, and we need to fix this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants