Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle external libraries? #3

Closed
flekschas opened this issue Aug 26, 2018 · 1 comment
Closed

How to handle external libraries? #3

flekschas opened this issue Aug 26, 2018 · 1 comment

Comments

@flekschas
Copy link

This is more of a question: I am wondering how external libraries can be handled? When the module I am testing imports some other external library like so:

import test from 'test';

The Rollup's code output contains that import statement (i.e., code: 'import \'test\';\n'). Hence, agadoo doesn't attest full shakability.

I guess my question is whether this is expected and if agadoo would just have to take this into account when testing for shakability or if something else needs to be adjusted.

@billiegoose
Copy link

Currently the definition of success is if calling rollup on

import ${JSON.stringify(resolved)}

results in an empty string.

What if we expanded the definition of success to be results in an empty string or a string containing ONLY external import statements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants