Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Unexpected token' check is breaking a bunch of Svelte tests #33

Closed
Conduitry opened this issue Feb 7, 2020 · 3 comments
Closed

'Unexpected token' check is breaking a bunch of Svelte tests #33

Conduitry opened this issue Feb 7, 2020 · 3 comments

Comments

@Conduitry
Copy link
Collaborator

Conduitry commented Feb 7, 2020

The 'Unexpected token' check added in #32 is introducing a lot of false positives or something, because hundreds of Svelte tests are failing now. I'm not sure why.

@Conduitry Conduitry changed the title 'failed to parse' check is breaking a bunch of Svelte tests 'Unexpected token' check is breaking a bunch of Svelte tests Feb 7, 2020
@Conduitry
Copy link
Collaborator Author

It looks like this is partially the result of using the x function in Svelte on things ending in a semicolon, which I guess is technically incorrect. Some failing tests are from something else though. Continuing to investigate whether this is something that should be addressed in Svelte of code-red.

@Conduitry
Copy link
Collaborator Author

All failing tests can be addressed by fixing how we're calling code-red throughout the Svelte compiler - by making sure we're using b instead of x where appropriate, by making sure we're not closing expressions in extraneous parentheses, and in a couple of places by removing stray }s. Closing.

@Conduitry
Copy link
Collaborator Author

Issues revealed by upgrade fixed in sveltejs/svelte#4385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant