You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
First of all, nice project! I want to point out an issue I found recently. I tried implementing this in one of my projects but the Container wouldn't render so I ended up tracing the error to the componentWillMount lifecycle method of the Container, specifically to this line: https://github.com/RickWong/react-transmit/blob/master/src/lib/createContainer.js#L239. Going down that function call I noticed that this function returns false if the isRootContainer property of the Container is false, which in my case was because I hadn't declared initialVariables (https://github.com/RickWong/react-transmit/blob/master/src/lib/createContainer.js#L30). Once I set initialVariables to {} it worked as expected, but in my humble opinion that should have been uneccesary as I don't use any variables in my fragment functions. Or is this behaviour intended?
EDIT: Even if this behaviour is intended I don't think it should fail silently.
The text was updated successfully, but these errors were encountered:
I'll just quote from closed issue #49 where @RickWong said:
I really need to document this somewhere. Containers with initialVariables are so-called "root containers" and their fragments are fetched at start. Containers without initialVariables will never be automatically fetched. It's by design.
Console warnings (though I've been reading they aren't portable) and something in the docs might be useful. I won't be available for a couple of days so that is as much help as I can give.
First of all, nice project! I want to point out an issue I found recently. I tried implementing this in one of my projects but the Container wouldn't render so I ended up tracing the error to the
componentWillMount
lifecycle method of the Container, specifically to this line: https://github.com/RickWong/react-transmit/blob/master/src/lib/createContainer.js#L239. Going down that function call I noticed that this function returns false if theisRootContainer
property of the Container is false, which in my case was because I hadn't declaredinitialVariables
(https://github.com/RickWong/react-transmit/blob/master/src/lib/createContainer.js#L30). Once I setinitialVariables
to{}
it worked as expected, but in my humble opinion that should have been uneccesary as I don't use any variables in my fragment functions. Or is this behaviour intended?EDIT: Even if this behaviour is intended I don't think it should fail silently.
The text was updated successfully, but these errors were encountered: