wrong tar command

[jmickle]

when /gz|tgz|tar|bz2|tbz/
  execute "extract_artifact!" do
    command "tar xf #{cached_tar_path} -C #{release_path}"

this is surprising this works, assuming you are using a .tar file explicitly. This is the wrong subset of commands for file types and extraction.

[awillis]

Yes I agree, this looks wrong.

[capoferro]

What specifically is wrong? Are you able to provide a fix?

Is it that it's missing the z for gzipped files?

[awillis]

The x and f options say extract and specify the file. There are no options here for the specific type of compression used. The tar format itself does not do compression.

[awillis]

The j option is needed for bzip2 and the z option for zlib compression.

[capoferro]

Cool, we'd definitely accept a PR fixing this.

[jmickle]

yeah i can break this out and PR it i suppose

[awillis]

Yah I was going to submit a PR sometime this week.

[jmickle]

Awesome @awillis you on this one? I can focus on 142 if you are

[awillis]

Yup, I've got it

[jmickle]

great i will focus on 142 then and get that in the next couple of days :-)

[jmickle]

@awillis any update on this?

[awillis]

#148

Sorry for the delay, been busy with work stuff. I don't have any test artifacts to test it with, perhaps you do?

[jmickle]

all ive got from nexus are tar.gz's etc, maybe this would be a good use case for the unit tests?

[awillis]

A test with a tar.gz only is fine. We're not resting the tar programs ability to decompress archives, just the providers ability to pass the right options. You might also rename the tar.gz as tgz and test that, and decompress it using gzip and test with the resultant tar.

[florentdupont]

Tested using tar.gz => failed
For tgz extension => I confirm it's working.

Concerning the tar.gzfailure. The problem is not the tar command but the previous test with the extension. I provided a correction in PR #156.

[glenjamin]

It's worth noting that (at least) GNU tar detects the compression type based on filename, so this will only fail when using older versions of tar.

[BarthV]

-1 !
Tar command auto detect archive format for ages !
Providing -z or -j is not a good recommandation anymore ...