use different venv during local development and during cicd

[copdips]

Hello,

I'm using pyright by is public github action. and I see that pyright has a param venv which can specify the venv path, I would like to know that, during the local development, I use venv, it's OK. But during the CICD, I don't use venv, just install everything at system level, in such case, how to keep a single pyproject.toml but with different venv ?
Does pyright support find automatically the package installation path based on python executable used.
It seems that mypy can do that, we do not need to specify which venv to use, just run mypy

[ryanpeach]

Same

[RobertCraigie]

For most use cases you shouldn't need to explicitly specify a virtual environment path, you can instead activate your environment before running pyright and it will be picked up automatically.

[copdips]

For most use cases you shouldn't need to explicitly specify a virtual environment path, you can instead activate your environment before running pyright and it will be picked up automatically.

Hello @RobertCraigie

Thank you for taking the time to reply to this issue.
However, I believe there might be a misunderstanding.
The reason I raised this issue is that Pyright installed from the repository cannot automatically detect the virtual environment (venv), and you provided a workaround by suggesting the use of the venv parameter in the pyproject.toml file.

Hereunder the guideline in the README.md:

[copdips]

And the reason I use Pyright installed from the repository and not from pip install pyright is that sometimes in CICD only Pyright doesn't work due to a 'file not found' error."

And I saw an issue and this issue discussing a race condition, is it related ?

[RobertCraigie]

Ah I see, you're specifically talking about pre-commit. Sorry for the misunderstanding.

I'm not sure if there's a great solution here unfortunately, I'm also not familiar with pre-commit anymore as I stopped using it years ago.

Would adding your dependencies to the pre-commit config work for you? https://pre-commit.com/#config-additional_dependencies

[RobertCraigie]

ah @copdips maybe this would be helpful? #203 (comment)

[copdips]

adding your dependencies

adding deps in pyright pre-commit conf requires us to declare them in 2 places, which I don't feel confortable with...

[copdips]

ah @copdips maybe this would be helpful? #203 (comment)

Thanks a lot, I didn't know pyright also has --pythonpath parameter.
This will definitely help, I will try using sys.executable first instead of os.path.realpath(sys.executable), as realpath reflects the system-level Python path, but not the one in venv.

[RobertCraigie]

adding deps in pyright pre-commit conf requires us to declare them in 2 places, which I don't feel confortable with...

oh there's no way to specify a requirements.txt or similar with pre-commit? would probably be worth filing a feature request with pre-commit if there isn't an existing one already