Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turtlesim: error handling when spawning turtle without name #2

Open
emmanuelkring opened this issue May 11, 2020 · 2 comments
Open

Comments

@emmanuelkring
Copy link

Spawning a new turtle in the turtle simulation without a name results in an error. The error message that is printed to the gui "Error on execution: Traceback ..." followed by a traceback. The error message should either be improved or the turtle should spawn with an empty string for a name.

Full error message:

error: Traceback (most recent call last):
File "/home/emmanuel/rvmi_ws/src/libs/skiros2/skiros2/skiros2_skill/src/skiros2_skill/core/visitors.py", line 159, in postProcessNode
state = self.postExecute(procedure)
File "/home/emmanuel/rvmi_ws/src/libs/skiros2/skiros2/skiros2_skill/src/skiros2_skill/core/skill_utils.py", line 294, in postExecute
state = self._postExecute(skill)
File "/home/emmanuel/rvmi_ws/src/libs/skiros2/skiros2/skiros2_skill/src/skiros2_skill/core/skill_utils.py", line 285, in _postExecute
return skill.tick()
File "/home/emmanuel/rvmi_ws/src/libs/skiros2/skiros2/skiros2_skill/src/skiros2_skill/core/skill.py", line 309, in tick
res = self.execute()
File "/home/emmanuel/rvmi_ws/src/libs/skiros2/skiros2/skiros2_skill/src/skiros2_skill/core/skill.py", line 517, in execute
res = self._instance.tick()
File "/home/emmanuel/rvmi_ws/src/libs/skiros2/skiros2/skiros2_common/src/skiros2_common/core/primitive.py", line 22, in tick
return_state = self.execute()
File "/home/emmanuel/rvmi_ws/src/libs/skiros2/skiros2_examples/src/skiros2_examples/turtlesim_example/turtlesim_primitives.py", line 42, in execute
turtle.label = "turtlebot:" + name
TypeError: cannot concatenate 'str' and 'NoneType' objects

@emmanuelkring
Copy link
Author

I just noticed the turtle is actually spawned despite the error message so the latter option might be more reasonable.

@emmanuelkring
Copy link
Author

On the other hand, it does not show up in the world model, only in the turtlesim window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant