Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with image topic published from webrtc_ros #45

Open
mjsobrep opened this issue May 7, 2020 · 2 comments
Open

Problem with image topic published from webrtc_ros #45

mjsobrep opened this issue May 7, 2020 · 2 comments

Comments

@mjsobrep
Copy link
Contributor

mjsobrep commented May 7, 2020

I have been having a problem where when a topic that is being published from webrtc_ros disconnects then reconnects all of the systems have a delay in getting the new feed if they have previously received the feed. If it is their first time getting the feed, then no problem. Except that nodes which subscribe using image transport seem ok.

more detail

I think there might be something that could be done to the video renderer to fix this. But I don't know what that would be.

@roehling
Copy link
Collaborator

roehling commented May 8, 2020

I haven't checked in the WebRTC code base, but this reminds me of a similar issue we had with encoded video bitstreams. If a video client joins an existing bitstream transmission later (i.e. not right from the beginning), it has to wait for the next key frame before it can start decoding, because the other frames only encode differences. Maybe the connection lingers and gets reused if you disconnect and reconnect?

@mjsobrep
Copy link
Contributor Author

mjsobrep commented May 8, 2020

Yeah, that is possible. My initial thought was that the that in a destructor, maybe the image transport should be closed, after being opened. But I dug into the docs a bit and it seems that should happen when it goes out of scope. I would think that the image publisher goes out of scope when the webrtc connection is closed here. That is where I will start debugging if I ever get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants