Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system-wide (hunspell) spell check languages #1077

Closed
2 tasks done
Forage opened this issue Feb 6, 2019 · 3 comments
Closed
2 tasks done

Use system-wide (hunspell) spell check languages #1077

Forage opened this issue Feb 6, 2019 · 3 comments

Comments

@Forage
Copy link

Forage commented Feb 6, 2019

My Setup

  • Operating System: Ubuntu 18.10
  • App Version: 2.14.7
  • Installation type: deb
  • I have tested with the latest version
  • I can simulate the issue easily

Description

RocketChat appears to be providing it's own (limited) set of spell check language files (/opt/Rocket.Chat/resources/dictionaries).
System-wide I already have multiple hunspell language packs installed to provide spell check files for multiple languages.
It's a shame those language files aren't used automagically.
There's an option provided to search for additional language files, but when using that to point to an existing hunspell file it will give an error that it failed to copy the files (needs root permissions).

Current Behavior

RocketChat is not using the system-wide spell check languages (hunspell packages)

Expected Behavior

RocketChat should be using the system-wide spell check languages (hunspell packages) instead of having to add/copy them manually.

@ml-
Copy link

ml- commented Feb 8, 2019

Related:

I also wanted this feature and ended up patching the AUR package which I now maintain.
The patch here: fix-dictionarties.patch

After digging through the code for a while, I ended up blaming it on the spellchecker package for failing to provide the default system dictionary path. But of course things aren't that easy, so I can't really go around pointing fingers at developers. It would be nice though to pass a flag or set an ENV var to provide the hunspell dictionaries path of the targeted distribution.

@tassoevan
Copy link
Collaborator

Over time, we've noticed that using global dictionaries is more confusing for users of other operating systems. Closing it while a better option for a good user experience is not suggested.

@Forage
Copy link
Author

Forage commented Feb 20, 2020

Too bad. It's the exact opposite that's true for Linux users so maybe it should not be treated as a general solution for all operating systems to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants