feat: Flash root window on all platforms #1949
Conversation
|
|
|
Hello, I have made the same kind of modification (allow Linux in addition to Windows) : I have tested it successfully (all mentions will triggers the taskbar flash). I think that it would be a great feature to support flashing for more platforms. Should I do another pull request ? |
|
I really agree this would be nice. I feel like it used to work for us in 2.X but i may be confused. I have team members using skype on their windows systems to let others know they have rocket chat messages waiting on the linux system. Testing this out locally, this is exactly what we want. |
Reduce win32 restriction for flashFrame
Mephistophiles
force-pushed
the
notifications
branch
from
d0dff84
to
7df2609
Compare
|
Oh, I based on the develop branch, my failure. Rebased on the master branch. |
tassoevan
changed the title
|
On linux, this change is causing the app to steal focus from other apps whenever the user is mentioned or receives a DM (even across different desktops) |
|
Yeah this is very annoying on linux. 🙈 Especially in i3 where focus means the mouse is also moved |
|
How about making the option "flash window on notifications" next to the "Show tray icon" (disabled for Linux by default)? |
|
I think i'd personally even be ok having to turn it off via a flag or environment variable. Cause I know adding an option is a good more work :) |
This commit adds 'Flash window on notifications' toggle to the menu. PR RocketChat#1949 introduced the flash window for all platforms, but for someone this feature was too annoying. Because of this was been added the menu toggle for enable/disable this feature.
This commit adds 'Flash window on notifications' toggle to the menu. PR RocketChat#1949 introduced the flash window for all platforms, but for someone this feature was too annoying. Because of this was been added the menu toggle for enable/disable this feature.
This commit adds 'Flash window on notifications' toggle to the menu. PR RocketChat#1949 introduced the flash window for all platforms, but for someone this feature was too annoying. Because of this was been added the menu toggle for enable/disable this feature.
Reduce win32 restriction for flashFrame
Maybe I should have an option in the config for this, what do you say?