Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Button Should be Unfocused Until Status Value Changes #5565

Closed
anirbanpaulcom opened this issue Feb 13, 2024 · 7 comments
Closed

Save Button Should be Unfocused Until Status Value Changes #5565

anirbanpaulcom opened this issue Feb 13, 2024 · 7 comments

Comments

@anirbanpaulcom
Copy link
Contributor

Description:

The Save button should only become focused when there is a change in the status.

Environment Information:

  • Rocket.Chat Server Version: 6.5.0
  • Rocket.Chat App Version: 4.47.0
  • Device Name: Redmi note 5 pro
  • OS Version: Android

Steps to reproduce:

  1. Go to "Edit Status"
  2. Observe the Save Button

Expected behavior:

The Save button should remain unfocused until there is a change in the value of the status. Once the status value changes, the Save button should become focused.

Actual behavior:

WhatsApp Image 2024-02-13 at 7 19 16 PM (1)

Additional context:

@anirbanpaulcom
Copy link
Contributor Author

@diegolmello , @GleidsonDaniel Please let me know if this functionality is required or not.

@groom115

This comment was marked as spam.

@diegolmello
Copy link
Member

@anirbanpaulcom When you say unfocused you mean disabled.
Yes, it's a valid improvement.

@groom115

This comment was marked as spam.

@anirbanpaulcom
Copy link
Contributor Author

Hey @diegolmello , Could you please take a look at this PR? Fix : #5569

@soCallmeAdityaKumar
Copy link

Hey @anirbanpaulcom if you are not working @diegolmello can you please assign it to me would be happy to work on this

@Rohit3523
Copy link
Contributor

Rohit3523 commented Nov 8, 2024

Fixed in #5569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants