Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CAS protocol as account/login possibility #1369

Closed
konsumate opened this issue Nov 10, 2015 · 12 comments
Closed

Add CAS protocol as account/login possibility #1369

konsumate opened this issue Nov 10, 2015 · 12 comments

Comments

@konsumate
Copy link
Contributor

Hey there,

It would be nice to have the Jasig CAS protocol as login possibility, there seems to exist a meteor cas binding already at https://github.com/tvoglund/meteor-accounts-cas

If I understood this correctly, a bit of attribute binding, saving settings and graphical exposure is missing in order to get this up and running?

THanks a bunch!

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@konsumate
Copy link
Contributor Author

Any directions or hints in order to get a prototype up and running with a current deploy from the Dockerfile? as in how to integrate this stuff with the node and folder structure of rocket.chat. Is a drop in sufficient? do the libraries need to be registered, exposed somehow?

@Sing-Li
Copy link
Member

Sing-Li commented Nov 19, 2015

@CoreCache This is a non trivial development effort. Assuming you are already familiar with Node.js, Coffeescript, and Meteor. Please catch one of the core developers on demo.rocket.chat. #dev channel
during UTC-4 working hours for some guidance. It would be a great feature to get working, and Rocket.Chat into the hands of more educators.

@engelgabriel
Copy link
Member

@CoreCache looks like you've done some progress on this? Do you want to do a PR adding your package so we can collaborate?

@engelgabriel
Copy link
Member

This issue will help with #322

@konsumate
Copy link
Contributor Author

Some untested work for CAS 1.0 (only username given upon auth, no attributes) has been done in https://github.com/corecache/Rocket.Chat/tree/cas - I'll want to roughly test this stuff before arranging a PR

@engelgabriel
Copy link
Member

Help testing this is welcome: #1970

@konsumate
Copy link
Contributor Author

Just in case, this only covers CAS 1.0 for now.

@konsumate
Copy link
Contributor Author

At least some progress was made here, the CAS 1.0 did work, the CAS module was able to identify users against the CAS service, but login them in into RocketChat failed somehow: After the user authenticated against cas, the popup window for the cas auth vanished but nothing happened, I guess there is some mismatch for the returning response.

Edit: For those who want to check the code which is beeing called for the LoginHandlers, see my forked Repo above.

@engelgabriel
Copy link
Member

@rodrigok is now focused on refactoring the LDAP package, maybe now it is a good time to collaborate, as they seem to share some logic.

@konsumate
Copy link
Contributor Author

I gave this another debugging session today and was able to get it up and running correctly.
The next steps include cleaning up the code, releasing the PR and some small twitch to show/hide the CAS login button depending on the plugin settings.

@konsumate
Copy link
Contributor Author

PullRequest: #2183

@rodrigok
Copy link
Member

Closed via #2183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants